Skip to content

Conversation

@alaaomri
Copy link

@alaaomri alaaomri commented Apr 4, 2025

fix typo in cleaning / uninstall kotlin extension + use default de.hybris.ant.taskdefs.YJavaC since it extends org.apache.tools.ant.taskdefs.Javac

…ris.ant.taskdefs.YJavaC since it extends org.apache.tools.ant.taskdefs.Javac
@mlytvyn
Copy link
Owner

mlytvyn commented Apr 5, 2025

@alaaomri , thank you for your contribution, I'll review it later today!

@mlytvyn
Copy link
Owner

mlytvyn commented Apr 5, 2025

@alaaomri , according to what I recall from the original approach is that using OOTB YJavaC ant task will not enable vice-versa visibility and compilation of the Kotlin <-> Java code, as it's using JDTCompilerAdapter (from Eclipse), which, as for now, does not support additional compiler adapters, such as KotlinCompilerAdapter enabled with the ant task <withKotlin/>.
more details:

p.s. we can have a live chat on this topic some day next week.

@alaaomri
Copy link
Author

alaaomri commented Apr 6, 2025

Thank you a lot for the extension and for making it open source
thanks for the explanations in the the previous comment
I adapted my PR

actually I am testing it in my local environment for developer , I had a problem when I switch to another branch without exectuting "ant kotlinnature_compile_mode -Dmode=uninstall" the build will fail :(
I am afraid that will have impact when build on sapcc cloud platform since we can't execute these command to uninstall kotlin
second issue, I have developed some tests classes , i placed them in kotlinttestsrc but when I launch a scan for Unit Test / Integration Test they are not visible :
Capture d’écran 2025-04-06 à 12 13 25
Capture d’écran 2025-04-06 à 12 15 20

Do you have any idea how to solve it ?

@mlytvyn
Copy link
Owner

mlytvyn commented Apr 6, 2025

@alaaomri , some time in 2023 I got a message on CCv2 support. There was, indeed, an issue with installing the adapter, but it was fixed by leveraging common properties, see 5566cad.

It can be installed via default build callback and should be picked up by the Ant.

Regarding the tests - haven't tried them, but 'src' worked for sure.

Maybe I will have a free minute someday next week to check the tests.

And last one, my intention to use "no space" in regex was to omit possible same modifications of the files per each invocation of the install.

p.s. each build in ccv2 is independent so there is no need to uninstall kotlin, it only has to be installed as part of the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants